This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
DM-12315: Generalize ap_pipe to non-HiTS data #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-12315
branch
from
2d78058
to
b42db3b
Compare
mrawls
reviewed
Aug 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds data-specific settings for
ApPipeTaskto the dataset. The settings include the use of CP biases and flats, the type of templates stored intemplates/, and refcat settings.An unfortunate side effect of this change is that now it's very difficult to run
ap_pipewithout a custom config for one's own refcats. The obs package defaults appear to work fine onlsst-dev, but I have not investigated this thoroughly.