Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-12315: Generalize ap_pipe to non-HiTS data #27

Merged
merged 5 commits into from Aug 7, 2018
Merged

Conversation

kfindeisen
Copy link
Member

This PR moves most of the config defaults out of the source code (see lsst-dm/legacy-ap_verify_hits2015#9, lsst/obs_decam#88, and lsst/obs_subaru#143). Note that, depending on the templates or refcats being used, runs of ap_pipe are much more likely to need a user config file.

This PR also makes some minor maintenance updates to ap_pipe.

@kfindeisen kfindeisen requested a review from mrawls July 24, 2018 21:13
"z": "z",
"y": "y",
"VR": "g"}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've moved all this refcat filterMap business into config/apPipe.py in ap_verify_hits2015. Do all our "datasets" now need to include a config like this in order to run ap_pipe on them? Could this information live in the obs_package's config/apPipe.py instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obs packages already have defaults (in processCcd.py) for lsst-dev:/datasets/refcats/htm/ps1_pv3_3pi_20170110. However, we use different refcats in the datasets (in particular, Gaia).

I think that if we're providing dataset-specific refcats, then we should provide the corresponding config in the dataset as a matter of self-consistency. Otherwise, changes to the refcats assumed by the obs package could break the dataset (though it may only be obvious if we're not running on lsst-dev).

@kfindeisen kfindeisen merged commit efff558 into master Aug 7, 2018
@kfindeisen kfindeisen deleted the tickets/DM-12315 branch February 25, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants