DM-6640: IsrTask is not a valid CmdLineTask #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Just be sure to test it with |
mfisherlevine
approved these changes
Sep 6, 2018
yalsayyad
reviewed
Sep 10, 2018
config/processCcd.py
Outdated
| from lsst.meas.algorithms import LoadIndexedReferenceObjectsTask | ||
| from lsst.meas.astrom import MatchPessimisticBTask | ||
| from lsst.utils import getPackageDir | ||
|
|
||
| ObsConfigDir = os.path.join(getPackageDir("obs_ctio0m9"), "config") |
There was a problem hiding this comment.
https://developer.lsst.io/python/style.html#id29
but all other names are camelCase with leading lowercase. In particular:
...
There was a problem hiding this comment.
Fixed across all obs_* packages.
czwa
force-pushed
the
tickets/DM-6640
branch
from
188e55e
to
a6e67f2
Compare
The IsrTask was not usable as a CmdLineTask, as it was written to be called as a subtask of ProcessCcdTask. This allows the default IsrTask to be retargeted to camera-specific versions of the ISR processing. A new RunIsrTask now exists to hold IsrTask for retargetting in standalone processing, and both processCcd.py and runIsr.py now read from the same configuration files for each obs_ package. This has involved migrating configuration values from config/processCcd.py to config/isr.py for many obs_ packages.
czwa
force-pushed
the
tickets/DM-6640
branch
from
a6e67f2
to
4a1accf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket adds a stand-alone runIsr.py script, as well as ensuring that runIsr.py and processCcd.py read the same ISR configuration files.