Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26867: Mark obs_ctio0m9 as deprecated #32

Merged
merged 1 commit into from Oct 5, 2020
Merged

Conversation

jdswinbank
Copy link
Contributor

No description provided.

Copy link
Contributor

@mfisherlevine mfisherlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

For the data up-to and including March 2017, this can be found in the /pre_ingest/sanitize.ipynb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any difference on this line so I'm not actually sure why it's showing in the changes, but obviously looks fine, given that it's apparently unchanged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line now ends with a new line character (which GitHub isn't displaying — I thought it had some symbol for that, but maybe not). This is almost always the right thing to do for a text file (https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline).

@jdswinbank jdswinbank merged commit 1ecf207 into master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants