Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-26867: Mark obs_ctio0m9 as deprecated #32

Merged
merged 1 commit into from
Oct 5, 2020
Merged

DM-26867: Mark obs_ctio0m9 as deprecated #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# obs_ctio0m9
A repository to hold the description for ctio0m9

*Warning:* This package is deprecated, and will be removed from the Rubin Observatory Science Pipelines distribution after release 21.0.0.

The data taking at this site was not fully automated, and so some header keywords are known to be unreliable.
Some of these are standardised during ingest by the obs_package (e.g. normalisation of filter naming,
ensuring the DATE-OBS keyword is ISO8601 compliant etc). However, some things are, by necessity, done
in a pre-ingest script (one needs to visually inspect flats to ensure they are not actually dispersed images)

For the data up-to and including March 2017, this can be found in the /pre_ingest/sanitize.ipynb
For the data up-to and including March 2017, this can be found in the /pre_ingest/sanitize.ipynb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any difference on this line so I'm not actually sure why it's showing in the changes, but obviously looks fine, given that it's apparently unchanged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line now ends with a new line character (which GitHub isn't displaying — I thought it had some symbol for that, but maybe not). This is almost always the right thing to do for a text file (https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline).

9 changes: 9 additions & 0 deletions doc/lsst.obs.ctio0m9/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
.. py:currentmodule:: lsst.obs.ctio0m9

.. _lsst.obs.ctio0m9:

################
lsst.obs.ctio0m9
################

.. warning:: This package is deprecated, and will be removed from the Rubin Observatory Science Pipelines after release 21.0.0.
5 changes: 5 additions & 0 deletions python/lsst/obs/ctio0m9/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
# the GNU General Public License along with this program. If not,
# see <http://www.lsstcorp.org/LegalNotices/>.
#
import warnings

warnings.warn('lsst.obs.ctio0m9 is deprecated; it will be removed from the Rubin Observatory'
'Science Pipelines after release 21.0.0', category=FutureWarning)

from .version import *
from .ctio0m9 import *
from .ctio0m9Mapper import *