Review for tickets/DM-3114: add aperture correction to SdssCalibrateTask #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the future, please put purely cosmetic changes from behavior changes (even cleanup behavioral changes). |
| @@ -255,6 +309,7 @@ def run(self, exposure, defects=None, idFactory=None): | |||
| backgrounds.append(bg) | |||
| self.display('background', exposure=exposure) | |||
|
|
|||
| # Make both tables from the same detRet, since detRet can only be run once | |||
There was a problem hiding this comment.
Quibble: detRet isn't run once, detection is.
There was a problem hiding this comment.
I got that quote from pipe_tasks CalibrateTask. I'll fix it in both places.
r-owen
force-pushed
the
tickets/DM-3114
branch
3 times, most recently
from
357e24e
to
98c057a
Compare
Add the newly standard subtask to measure aperture correction and boolean config to control it. Override the default field that MeasureApCorr uses to determine stars that are suitable. By default MeasureApCorr uses "calib_psfUsed", but PSF determination sets this field and PSF determination is rarely run on SDSS data, so change the default to "calib_psfCandidate" (which is set by star selection, which is always run on SDSS data). Also rename the field calib_psf_used to calib_psfUsed and calib_psf_candidate to calib_psfCandidate to match the standard CalibrateTask. This is relevant because one of these fields is used to measure aperture correction by default in CalibrateTask and the other by default in SdssCalibrateTask.
SdssCalibrateTask had diverged from CalibrateTask in various minor ways and this restores some of the similarity, including: - Return photocal data in run's results - Put calibration info into the task metadata - Cosmetic changes Some changes were retained that could perhaps have been removed, the most significant of which is that the SDSS version uses AstrometryTask instead of ANetAstrometryTask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.