Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review for tickets/DM-3114: add aperture correction to SdssCalibrateTask #3

Merged
merged 2 commits into from
Jul 29, 2015
Merged

Review for tickets/DM-3114: add aperture correction to SdssCalibrateTask #3

merged 2 commits into from
Jul 29, 2015

Commits on Jul 29, 2015

  1. Add aperture correction to obs_sdss's CalibrateTask. 

    Add the newly standard subtask to measure aperture correction and boolean config to control it.
Override the default field that MeasureApCorr uses to determine stars that are suitable.
By default MeasureApCorr uses "calib_psfUsed", but PSF determination sets this field
and PSF determination is rarely run on SDSS data, so change the default to "calib_psfCandidate"
(which is set by star selection, which is always run on SDSS data).

Also rename the field calib_psf_used to calib_psfUsed and calib_psf_candidate
to calib_psfCandidate to match the standard CalibrateTask. This is relevant
because one of these fields is used to measure aperture correction by default
in CalibrateTask and the other by default in SdssCalibrateTask.
    @r-owen
    r-owen committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    bb4262a View commit details
    Browse the repository at this point in the history

  2. Make SdssCalibrateTask more like pipe_tasks CalibrateTask 

    SdssCalibrateTask had diverged from CalibrateTask in various minor ways
and this restores some of the similarity, including:
- Return photocal data in run's results
- Put calibration info into the task metadata
- Cosmetic changes
Some changes were retained that could perhaps have been removed,
the most significant of which is that the SDSS version uses
AstrometryTask instead of ANetAstrometryTask.
    @r-owen
    r-owen committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    9ab7db6 View commit details
    Browse the repository at this point in the history