Replace boost::lexical_cast with std equivalent #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary change is a replacement of boost::lexical_cast with std::to_string. However validateBasic unfortunately is structured in such a way that to_string would be called with non-arithmetic types. Although the relevant branch would never actually execute, the fact that boost::lexical_cast allows casting from pretty much any type, whereis std::to_string only takes arithmetic types bites us here. To resolve this the problematic value is simply not printed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change is a replacement of boost::lexical_cast
with std::to_string. However validateBasic unfortunately
is structured in such a way that to_string would be called
with non-arithmetic types. Although the relevant branch
would never actually execute, the fact that boost::lexical_cast
allows casting from pretty much any type, whereis std::to_string
only takes arithmetic types bites us here. To resolve this the
problematic value is simply not printed.