Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::lexical_cast with std equivalent #4

Merged
merged 1 commit into from
Jun 2, 2016
Merged

Replace boost::lexical_cast with std equivalent #4

merged 1 commit into from
Jun 2, 2016

Commits on Jun 2, 2016

  1. Replace boost::lexical_cast with std equivalent 

    The primary change is a replacement of boost::lexical_cast
with std::to_string. However validateBasic unfortunately
is structured in such a way that to_string would be called
with non-arithmetic types. Although the relevant branch
would never actually execute, the fact that boost::lexical_cast
allows casting from pretty much any type, whereis std::to_string
only takes arithmetic types bites us here. To resolve this the
problematic value is simply not printed.
    Pim Schellart authored and Pim Schellart committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    9e983fe View commit details
    Browse the repository at this point in the history