DM-30284: Accommodations towards Gen2/Gen3 parity and determinism in coaddition #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-30284
branch
2 times, most recently
from
07115e4
to
6b4691e
Compare
laurenam
force-pushed
the
tickets/DM-30284
branch
from
6b4691e
to
9533a96
Compare
laurenam
force-pushed
the
tickets/DM-30284
branch
from
9533a96
to
35a4d0b
Compare
yalsayyad
approved these changes
Jan 9, 2022
| expId = getGen3CoaddExposureId( | ||
| patchRef, coaddName=self.detectCoaddSources.config.coaddName, log=self.log) | ||
| except Exception as e: | ||
| self.log.warn("Setting exposureId to match Gen3 failed with: %s. Falling back to " |
There was a problem hiding this comment.
This log message was really helpful, so please add it to the try: getGen3CoaddExposureId blocks you have in pipe_tasks and meas_base too. I wish I looked at this repo first.
There was a problem hiding this comment.
Sorry again...the try/except/log.warning are all now in the getGen3CoaddExposureId function itself, so removed it here.
This is temporary functionality to aid with the Gen2 to Gen3 middleware migration. In particular, the ID integer associated with a particular coadd exposure was computed differently between the two middlewares. This number is used in places a seed for random number generation used in certain algorithms (e.g. dynamic detection). This seed value must match in both middlewares if parity is to be achieved, so here we update the expId evaluation in Gen2 to match that of Gen3.
Order of inputs is not guaranteed, and the weighting per detector to the full focal plane sky model can depend (very weakly) on the order of inputs, so sort them by detector to guarantee reproducible results for the same set of inputs.
laurenam
force-pushed
the
tickets/DM-30284
branch
from
35a4d0b
to
d30f4d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.