Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30284: Accommodations towards Gen2/Gen3 parity and determinism in coaddition #100

Merged
merged 2 commits into from
Jan 11, 2022
Merged

DM-30284: Accommodations towards Gen2/Gen3 parity and determinism in coaddition #100

merged 2 commits into from
Jan 11, 2022

Commits on Jan 10, 2022

  1. Make use of Gen3-mimicking getGen3CoaddExposureId 

    This is temporary functionality to aid with the Gen2 to Gen3 middleware
migration.  In particular, the ID integer associated with a particular
coadd exposure was computed differently between the two middlewares.
This number is used in places a seed for random number generation used
in certain algorithms (e.g. dynamic detection).  This seed value must
match in both middlewares if parity is to be achieved, so here we update
the expId evaluation in Gen2 to match that of Gen3.
    @laurenam
    laurenam committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    c78ce57 View commit details
    Browse the repository at this point in the history

  2. Sort by detector id to ensure reproducibility 

    Order of inputs is not guaranteed, and the weighting per detector to the
full focal plane sky model can depend (very weakly) on the order of inputs,
so sort them by detector to guarantee reproducible results for the same set
of inputs.
    @laurenam
    laurenam committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    d30f4d5 View commit details
    Browse the repository at this point in the history