DM-16343: Limit number of flake8 jobs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-16343
branch
from
04c2530
to
7a34778
Compare
|
I have submitted this patch upstream as tholo/pytest-flake8#55 |
TallJimbo
approved these changes
Oct 30, 2018
| if statistics: | ||
| args += ['--statistics'] | ||
| + # One file per flake8 call so limit flake8 to one job | ||
| + args += ['--jobs', "0"] |
There was a problem hiding this comment.
Both work and both turn off multiprocessing. Looking at the code 0 is used for number of jobs when the number of jobs can't be determined. I can go either way on this since the effect is the same.
Without this change flake8 uses "auto" meaning that each flake8 test for each file launches many subprocesses.
timj
force-pushed
the
tickets/DM-16343
branch
from
7a34778
to
47ebee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.