-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit flake8 to a single job per test #55
Conversation
8d08d2f
to
8032e1b
Compare
I am getting the tox failure even on master so I'm not sure what is going wrong. This patch fixes my local installation and makes things significantly faster. |
8032e1b
to
c8641c2
Compare
if case this is true I am looking forward for this change merged. In connection to failed Travis build. I think it was temporary issues on Travis or Github. I think new build could fix this error. |
8fcf45b
to
387c08d
Compare
I've rebased against current master and I hope the travis checks work this time. This fix really makes a huge performance difference when using this plugin and is critical for people who use |
@tholo I rebased and I still get tox errors. They don't seem to be related to my PR. |
Without this change flake8 creates many subprocesses every time it is invoked. This causes significant overhead and slows down test execution. In conjunction with pytest-xdist many hundreds of additional flake8 processes can be created which causes significant load issues.
387c08d
to
876093d
Compare
Rebasing again has finally sorted out the travis failures. |
Is there anything else I can do to help this PR get merged? |
@tholo What can we do to help this PR get merged? |
It looks like flake8 has been modified to make this issue go away. |
Without this change flake8 creates many subprocesses every time
it is invoked. This causes significant overhead and slows down
test execution. In conjunction with pytest-xdist many hundreds
of additional flake8 processes can be created which causes
significant load issues.