DM-10946: Non-square MatrixMap composed with a ShiftMap cannot be simplified #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. if the simplification process assumes that an inverse transformation is available, but doesn't actually check that it is available, then an error may occur during simplification. Reporting an error is such cases is bad - a clone of the supplied mapping should be returned instead. One way to fix this is for each and every mapping class to check that the required transformation exists before using it. But making these changes would be laborious and error prone. So instead, just put the check in the astSimplify_ wrapper in the base Mapping class - if a "transformation undefined" error occurs during simplification, annull the error and return a clone of the supplied Mapping.
kfindeisen
approved these changes
Jun 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.