Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10946: Non-square MatrixMap composed with a ShiftMap cannot be simplified #6

Merged
merged 3 commits into from
Jun 16, 2017
Merged

DM-10946: Non-square MatrixMap composed with a ShiftMap cannot be simplified #6

merged 3 commits into from
Jun 16, 2017

Commits on Jun 16, 2017

  1. Fix error checking when multiplying matrixmaps

    David Berry committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    05d2e24 View commit details
    Browse the repository at this point in the history

  2. Handle simplifications that fail due to inappropriate mappings 

    E.g. if the simplification process assumes that an inverse transformation
is available, but doesn't actually check that it is available, then an
error may occur during simplification. Reporting an error is such cases
is bad - a clone of the supplied mapping should be returned instead. One
way to fix this is for each and every mapping class to check that the
required transformation exists before using it. But making these changes
would be laborious and error prone. So instead, just put the check in the
astSimplify_ wrapper in the base Mapping class - if a "transformation
undefined" error occurs during simplification, annull the error and
return a clone of the supplied Mapping.
    David Berry committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    d0e8d28 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into lsst-dev

    @r-owen
    r-owen committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    ae5611c View commit details
    Browse the repository at this point in the history