Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working EUPS packaging of treecorr #1

Merged
merged 2 commits into from Jul 28, 2017
Merged

Add working EUPS packaging of treecorr #1

merged 2 commits into from Jul 28, 2017

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Jul 27, 2017

No description provided.

@wmwv wmwv requested a review from timj July 27, 2017 20:59
timj
timj requested changes Jul 27, 2017
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe you need the .cfg file for a python package. The .cfg file allows scons to work out what include paths and libraries to use when linking.

Also, do you need the build() override in the .cfg.sh file? It seems to build for me without it.

@wmwv
Copy link
Contributor Author

wmwv commented Jul 28, 2017

Thank you. treecorr.cfg removed. build() {...} removed from eupspkg.cfg.sh.

@wmwv
Copy link
Contributor Author

wmwv commented Jul 28, 2017

Forced-pushed an updated branch that rebase squashed over these unneeded bits.

@wmwv wmwv merged commit dabafef into master Jul 28, 2017
@ktlim ktlim deleted the tickets/DM-9961 branch August 25, 2018 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wmwv @timj