Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add working EUPS packaging of treecorr #1

Merged
merged 2 commits into from
Jul 28, 2017
Merged

Add working EUPS packaging of treecorr #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb557c2
Add UPS config dir and files.
wmwv Jul 27, 2017
dabafef
Improve README formatting.
wmwv Jul 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 7 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,15 @@ EUPS packaged version of Mike Jarvis' TreeCorr

https://github.com/rmjarvis/TreeCorr/archive/v3.2.3.tar.gz

# Explanatory Notes
# 2017-07-27: Michael Wood-Vasey
### Explanatory Notes
2017-07-27: Michael Wood-Vasey
1. We have specifically pinned to the 3.2.3 version
to avoid the `libffi`, `cffi`, `pyfits` dependencies introduced in more recent versions. These dependencies make sense for `TreeCorr` qua `TreeCorr`, but add dependencies to the LSST validate_drp stack that we wish to avoid for now.

In the future we may update. `libffi` and `cffi` should be set up as shim packages, particularly because `libffi` is available on many systems. The `pyfits` dependency we would have to step around because we do wish to avoid adding a 3rd (4th?) different python FITS interface to the LSST stack.

For more discussion see
- In the future we may update. `libffi` and `cffi` should be set up as shim packages, particularly because `libffi` is available on many systems. The `pyfits` dependency we would have to step around because we do wish to avoid adding a 3rd (4th?) different python FITS interface to the LSST stack.
- For more discussion see
https://jira.lsstcorp.org/browse/RFC-296
- If performance becomes an issue, we may want to update to more recent TreeCorr. But currently basic I/O from the catalog files dominates any in-memory correlation calculations. Thus until it becomes a performance bottleneck, I judge that the dependency minimization is the better option for the LSST validate_drp stack.

If performance becomes an issue, we may want to update to more recent TreeCorr. But currently basic I/O from the catalog files dominates any in-memory correlation calculations. Thus until it becomes a performance bottleneck, I judge that the dependency minimization is the better option for the LSST validate_drp stack.

2. "pandas" could be a setupOptional dependency.
2. `pandas` could be a `setupOptional` dependency.
If pandas is not present, then reading of ASCII catalogs will be slower.
But because we don't use that functionality, I've left that out as a dependency.
But we don't use that functionality, so I've left `pandas` out as a dependency.
1 change: 1 addition & 0 deletions ups/eupspkg.cfg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TAP_PACKAGE=1
2 changes: 2 additions & 0 deletions ups/treecorr.table
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
setupRequired(numpy)
setupRequired(pyyaml)