DM-6086: JSON serialization for the SQuaSH dashboard application #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
force-pushed
the
tickets/DM-6086
branch
from
454cd9b
to
1d6f851
Compare
The Datum data structure wraps a value and annotates it with a name, plot label and units (integrated with Astropy units). Currently skips unit validation checks for millimag units. We need to add 'millimag' as an Astropy unit derived from 'mag'. Includes a unit tests.
The Blob and Parameters serializers are baseclasses that can be extended for specialized schemas for different metrics WIP MeasurementSerializer Implement all serializers Fix serializer base inits
This allows the serializers to know what bandpass is being used.
This serializes matched star catalog statistics along with fits to the astrometric and photometric error models.
In calcSrd there are serializers that define the metrics as well as serializers that define parameter sets. In validate the measurements are captured with a MeasurementSerializer. This setup can certainly be refactored, streamlined, and made more robust by turning the measurement functions into classes that implement an API that consistently provides the measurement itself in addition to metadata.
Implements both parameter serializers specific for these measurements, and the serialization itself as part of the validate core executable.
jonathansick
force-pushed
the
tickets/DM-6086
branch
from
1d6f851
to
e7bbaed
Compare
|
👍 This implementation seems reasonable under the circumstances. |
|
I ❤️ the vote of confidence 💯. |
|
And for posterity, we're going to fix the architecture in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an extensible and consistent JSON schema for
validate_drpoutput that is compatible with post-qa and the SQuaSH dashboard. The schema will ultimately allow SQuaSH users to inspect rich metadata surrounding metrics, in addition to the scalar metric measurements themselves. The schema is also self-documenting, and leverages Astropy units to annotate numeric values.The schema itself is described in SQR-009. It is implemented through a group of Serialization classes whose role is to take data and render it into JSON through
jsoninstance properties. The serializers recursively serialize embedded documents.The current implementation purposefully leaves the original implementation of
validate_drpuntouched at the expense of some fragility and repetition in metadata management. A future PR will create a standardized API for measurement classes that take serialization needs into account.