DM-11215 #45
Merged
DM-11215 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to fail and crash just because we couldn't make a plot.
No need to separately pass matchedDataset, photomModel, astromModel. This increases the convenience for using these functions outside of 'run' or 'runOneFilter' and clarifies what data is being used.
We want the text output quickly. We can wait a bit for the plots.
This is in essence half the big test. If we load a file do we get printed metrics. Next todo is to actually check for a value.
Use .measurements iterator to access filter_name.
… case. If a metrics dictionary is passed, then will use and print only those metrics.
jonathansick
commented
Jul 17, 2017
python/lsst/validate/drp/validate.py
Outdated
| This can also be the filepath for a JSON file that contains | ||
| the cached output from a previous run. | ||
| """ | ||
| if repo_or_json[-5:] == '.json': |
There was a problem hiding this comment.
Typically you write this as if os.path.splitext(repo_or_json)[-1] == '.json'
There was a problem hiding this comment.
Oh, yes, thank you. That was a bit sloppy.
In practice this shouldn't make it a difference because we're only matching the exact string '.json', but os.path.splitext is certainly conceptually much more clear and expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.