tickets/DM-14216: Remove filter from metadata search #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For specs that don't depend on filter, the filter_name can simply be omitted.
|
So this is my best solution: specs = release_specs.subset(
required_metadata={'instrument':row['Instrument']})
specs = {name: spec for name, spec in specs.items()
if 'filter_name' not in spec._metadata_query.terms
or spec._metadata_query.terms['filter_name'] == row['Filer']}Unfortunately, it relies on a private attribute, so this is a use case we'll want to better support in I think it would be good to expose those metadata query terms from the specification more readily. The other thing I wonder is whether you can tag the specifications you want, and then query for those tags? |
SimonKrughoff
force-pushed
the
tickets/DM-14216
branch
from
8493573
to
52a964b
Compare
jonathansick
approved these changes
May 3, 2018
| @@ -139,7 +144,7 @@ def run(repo_or_json, metrics=None, | |||
| return | |||
|
|
|||
| json_path = repo_or_json | |||
| job = load_json_output(json_path) | |||
| job = load_json_output(json_path, **kwargs) | |||
There was a problem hiding this comment.
What do we expect these kwargs to be? might be worth documenting a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For specs that don't depend on filter, the filter_name can simply be omitted.