DM-43472: Prompt Processing version 2 not compatible with Butler dimensions-config 6 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid potential deadlocks from trying to export all dimensions in parallel, we instead export a hardcoded list of dimensions. This commit adds a guard that ignores any dimensions that don't exist in the current Butler version. This guard is exercised by our unit tests, which use a version 4 repo.
This dimension is defined at ingest time, but our developer repos do not guarantee that ingestion happens at all.
kfindeisen
force-pushed
the
tickets/DM-43472
branch
from
d236b05
to
254e553
Compare
timj
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a compatibility patch to keep Prompt Processing from crashing when working with version 6 central repositories.
Backwards-compatibility has been verified with unit tests, which emulate a version 4 repo.