Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43472: Prompt Processing version 2 not compatible with Butler dimensions-config 6 #143

Merged
merged 2 commits into from
Mar 23, 2024
Merged

DM-43472: Prompt Processing version 2 not compatible with Butler dimensions-config 6 #143

merged 2 commits into from
Mar 23, 2024

Commits on Mar 23, 2024

  1. Add safeguard to dimension export to central repo. 

    To avoid potential deadlocks from trying to export all dimensions in
parallel, we instead export a hardcoded list of dimensions. This commit
adds a guard that ignores any dimensions that don't exist in the
current Butler version.

This guard is exercised by our unit tests, which use a version 4 repo.
    @kfindeisen
    kfindeisen committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    07a7eeb View commit details
    Browse the repository at this point in the history

  2. Export group definition to central repo. 

    This dimension is defined at ingest time, but our developer repos do
not guarantee that ingestion happens at all.
    @kfindeisen
    kfindeisen committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    254e553 View commit details
    Browse the repository at this point in the history