IT-1686: add NFS module, nfs profile #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
approved these changes
Feb 6, 2020
adrienthebo
changed the title
jhoblitt
requested changes
Feb 6, 2020
Puppetfile
Outdated
| @@ -38,6 +38,8 @@ mod 'puppetlabs/mailalias_core', '1.0.5' | |||
| mod 'puppetlabs/docker', '3.8.0' | |||
| mod 'puppetlabs/reboot', '2.2.0' | |||
| mod 'puppet/python', '3.0.1' | |||
| mod 'derdanne/nfs', '2.1.2' | |||
| mod 'puppet-posix_acl', '1.0.0' | |||
There was a problem hiding this comment.
This is a nit-pick but I would like to consistently use / or - as the separator.
There was a problem hiding this comment.
I've reverted this commit, please take another look.
adrienthebo
force-pushed
the
IT-1686/nfs
branch
from
ca60579
to
02f965a
Compare
adrienthebo
force-pushed
the
IT-1686/nfs
branch
from
02f965a
to
f25e127
Compare
jhoblitt
approved these changes
Feb 10, 2020
hreinking
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an NFS module for managing nfs exports and mounts, and
adds in some shims in our profile module to define NFS exports and mounts in
hiera.
I propose that we fork the derdanne/nfs module, apply some fixups, and inject
the hiera resource creation directly into the module. We can push these changes
upstream.