IT-1778 use lsst-it tuned module #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
approved these changes
Feb 20, 2020
@jhoblitt Thanks for reviewing. I don't follow you on your comment. Can you elaborate? |
andylytical
force-pushed
the
IT-1778/fix-tuned-module
branch
from
49e4ddc
to
2b5236a
Compare
Ahha, I see what you're referring to. I'll pull that out into it's own change. |
Fixes puppet fact error message REVERT: Also removed references to IT-1383 ... to be done in a separate branch
andylytical
force-pushed
the
IT-1778/fix-tuned-module
branch
from
89ff971
to
eb1eb46
Compare
|
Pulled out the mod change for baseling_cfg into it's own branch. I'm going to merge this now. |
jhoblitt
pushed a commit
to jhoblitt/lsst-itconf
that referenced
this pull request
Mar 6, 2020
Queued changes into production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move forked tuned module into lsst-it github organization.
Caveat from #28
Fork Fixes puppet fact error message ...
Error: Facter: error while resolving custom fact "tuned_version": undefined method `empty?' for nil:NilClassAlso removed references to IT-1383