(profile::core::dtn) rm tql_tunning service; replace with NM dispatch #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tql_tunning` service is being invoked on every puppet run. This is undesirable as it makes it appear if the puppet state on the node is not converged. Running interface tuning commands as a one-off is also undesirable as parameters may be lost when the interface goes up and down. The NM dispatch script hooks are a more reliable option. Additionally, interface name specific configuration generally should not be baked into a profile class as it is inherently tied to a hosts hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tql_tunningservice is being invoked on every puppet run. This isundesirable as it makes it appear if the puppet state on the node is
not converged. Running interface tuning commands as a one-off is also
undesirable as parameters may be lost when the interface goes up and
down. The NM dispatch script hooks are a more reliable option.
Additionally, interface name specific configuration generally should not
be baked into a profile class as it is inherently tied to a hosts
hardware.