add spec coverage for all roles #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
IT-3057/role-tests
branch
from
4966ff8
to
c03fc96
Compare
jhoblitt
force-pushed
the
IT-3057/role-tests
branch
from
c03fc96
to
ac04172
Compare
jhoblitt
force-pushed
the
IT-3057/role-tests
branch
from
ac04172
to
3b23896
Compare
jhoblitt
changed the title
jhoblitt
force-pushed
the
IT-3057/role-tests
branch
from
3b23896
to
ac5ee9e
Compare
jhoblitt
force-pushed
the
IT-3057/role-tests
branch
from
ac5ee9e
to
160f5be
Compare
puppetlabs/selinux_core is an undeclared dep of puppet/selinux. See: voxpupuli/puppet-selinux#355
jhoblitt
force-pushed
the
IT-3057/role-tests
branch
from
cef5ec1
to
8587f0b
Compare
jhoblitt
commented
Jul 29, 2022
|
|
||
| require 'spec_helper' | ||
|
|
||
| role = 'generic' |
cbarria
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Lots of changes from several commits, everything good 👍
- removed file (ipa servers will use the ipareplica roll)
- dns forwarder for Tucson Site fixed
- rearrenged order hiera
- added test for most roles
- added selinux dependencie not declared
- testing OS for ubuntu 20.04 and 22.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least basic spec coverage for all roles is desired as preparation for adding EL8 support to most roles. If an existing role does not have a dedicated
_spec.rbfile it will automatically be tested as if it is a "common" role.based on: