Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(common) fix setting of yum::plugin::versionlock::clean param #614

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

jhoblitt
Copy link
Member

The current syntax is nonsense. There is no versionlock param on the
yum::plugin class to pass a hash into.

based on:
-#610

@jhoblitt jhoblitt requested a review from cbarria July 28, 2022 22:20
@jhoblitt jhoblitt marked this pull request as draft July 28, 2022 22:20
@jhoblitt jhoblitt marked this pull request as ready for review July 28, 2022 22:24
jhoblitt added a commit that referenced this pull request Jul 28, 2022
jhoblitt added a commit that referenced this pull request Jul 28, 2022
@jhoblitt jhoblitt force-pushed the IT-3057/fix-yum-versionlock-clean branch from 394ec39 to 680db6a Compare July 28, 2022 22:48
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i saw these changes when reviewing #610 👍

The current syntax is nonsense.  There is no `versionlock` param on the
`yum::plugin` class to pass a hash into.
@jhoblitt jhoblitt force-pushed the IT-3057/fix-yum-versionlock-clean branch from 680db6a to 3a7b486 Compare July 29, 2022 22:51
@jhoblitt jhoblitt merged commit 995338d into master Jul 29, 2022
@jhoblitt jhoblitt deleted the IT-3057/fix-yum-versionlock-clean branch July 29, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants