Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(!site/cp) set docker::log_opt log size limits #829

Merged
merged 1 commit into from May 23, 2023
Merged

(!site/cp) set docker::log_opt log size limits #829

merged 1 commit into from May 23, 2023

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented May 23, 2023 •
edited

Manually tested as working:

[jhoblitt@jhoblitt-test2 ~]$ docker inspect -f '{{.HostConfig.LogConfig}}' dfa822be71014968df58075bac6f9605fb7b97c3e6d41950c3d558e1471ec6a7
{json-file map[max-file:2 max-size:50m mode:non-blocking]}

@jhoblitt jhoblitt added the enhancement New feature or request label May 23, 2023
cbarria
cbarria approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! thanks for fixing this 👍🏻

@jhoblitt jhoblitt merged commit 18c0a3e into production May 23, 2023
8 checks passed
@jhoblitt jhoblitt deleted the IT-4499/docker-log_opt branch May 23, 2023 20:14
dtapiacl
dtapiacl reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@dtapiacl dtapiacl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtapiacl dtapiacl dtapiacl left review comments

@cbarria cbarria cbarria approved these changes

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

Assignees
No one assigned
Labels
enhancement New feature or request live-hosts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhoblitt @cbarria @dtapiacl