The negative values in un-rectified SED of SALT2 (and SALT2-extended) at #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extreme regions of the SNIa phase space can be a problem for codes that
sample the SED like phoSim. Therefore, this change implements:
rectified SED(lambda) = modelSED if SED(lambda) >= 0
= 0 if modelSED(lambda) < 0
This will cause the band flux and band mags (model values to be slightly
biased, but this should not matter much as they are truly small hen
compared to reasonable sky noise
modified: examples/testSN.py
modified: python/lsst/sims/catUtils/supernovae/snObject.py
modified: examples/testSN.py
replaced get_galacticRv in EBVMixin.py with get_galacticAv. galacticRv is now set to 3.1 as a default_column in all of the relevant InstanceCatalog classes. get_galacticAv mutiplies E(B-V) (from the SFD maps) by galacticRv to get galacticAv.
modified: examples/SNObject_example.ipynb
Added tests and examples for rectifySED
modified: examples/SNObject_example.ipynb
Added plots showing the behavior of rectifySED
modified: examples/testSN.py
Added tests checking the default attributes and their modification
behavior
modified: python/lsst/sims/catUtils/supernovae/snObject.py
split the attributes on rectify SED and outside model range behavior
extreme regions of the SNIa phase space can be a problem for codes that
sample the SED like phoSim. Therefore, this change implements:
rectified SED(lambda) = modelSED if SED(lambda) >= 0
= 0 if modelSED(lambda) < 0
This will cause the band flux and band mags (model values to be slightly
biased, but this should not matter much as they are truly small hen
compared to reasonable sky noise
modified: examples/testSN.py
modified: python/lsst/sims/catUtils/supernovae/snObject.py
modified: examples/testSN.py
modified: examples/SNObject_example.ipynb
Added tests and examples for rectifySED
modified: examples/SNObject_example.ipynb
Added plots showing the behavior of rectifySED
modified: examples/testSN.py
Added tests checking the default attributes and their modification
behavior
modified: python/lsst/sims/catUtils/supernovae/snObject.py
split the attributes on rectify SED and outside model range behavior
| @@ -9,7 +9,9 @@ | |||
| implementations of extinction using OD94 model.) | |||
| - Band Flux for extincted SED in r Band | |||
| - Band Mag for extincted SED in r Band | |||
|
|
|||
| - rectification of SED: while the SEDs from the model can go negative | |||
| resulting in negative model fluxes and adus. Test that if rectifySEDs in | |||
There was a problem hiding this comment.
typo: "in on" should be "is on"
…Utils into feature/rectifySNOBjectSED Fixed git clonflicts examples/testSN.py python/lsst/sims/catUtils/supernovae/snObject.py
|
OK ready for another look |
rbiswas4
added a commit
that referenced
this pull request
May 23, 2016
Feature/sn object sed regions : minor BugFix, Speedups and additional feature of SED rectification in sims_catUtils.supernovae.snobject.SNObject + new tests to check feature of SED rectification. BugFix : A bitwise and changed to and. Speedup: When the time of observation is outside the temporal range of the model, and uses the modelOutSideTemporalRange 'zero' where the SEDs are 0, speed catsimBandflux calculations by returning 0 rather than assigning zeros to the SED, and doing a bandflux calculation. SED rectification: At regions where the SALT model is poorly sampled in the training set, the SED can go negative. This forces such negative values to 0, which is important for tools like phosim that will sample the SED to generate photons. Tests are added. Jenkins testbuild https://ci.lsst.codes/job/stack-os-matrix/11442/ passes. Note: This is a duplicate of a previous mangled pull request #49. That PR has a few more commits and I will delete the branch later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extreme regions of the SNIa phase space can be a problem for codes that
sample the SED like phoSim. Therefore, this change implements:
rectified SED(lambda) = modelSED if SED(lambda) >= 0
= 0 if modelSED(lambda) < 0
This will cause the band flux and band mags (model values to be slightly
biased, but this should not matter much as they are truly small hen
compared to reasonable sky noise