Added a function to obtain the rest frame Sed source for phosim/galsim #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extreme regions of the SNIa phase space can be a problem for codes that
sample the SED like phoSim. Therefore, this change implements:
rectified SED(lambda) = modelSED if SED(lambda) >= 0
= 0 if modelSED(lambda) < 0
This will cause the band flux and band mags (model values to be slightly
biased, but this should not matter much as they are truly small hen
compared to reasonable sky noise
modified: examples/testSN.py
modified: python/lsst/sims/catUtils/supernovae/snObject.py
modified: examples/testSN.py
modified: examples/SNObject_example.ipynb
Added tests and examples for rectifySED
modified: examples/SNObject_example.ipynb
Added plots showing the behavior of rectifySED
modified: examples/testSN.py
Added tests checking the default attributes and their modification
behavior
modified: python/lsst/sims/catUtils/supernovae/snObject.py
split the attributes on rectify SED and outside model range behavior
replaced get_galacticRv in EBVMixin.py with get_galacticAv. galacticRv is now set to 3.1 as a default_column in all of the relevant InstanceCatalog classes. get_galacticAv mutiplies E(B-V) (from the SFD maps) by galacticRv to get galacticAv.
modified: examples/SNObject_example.ipynb modified: python/lsst/sims/catUtils/supernovae/snObject.py
modified: examples/SNObject_example.ipynb modified: python/lsst/sims/catUtils/supernovae/snObject.py
modified: supernovae/snObject.py
|
It looks like some of the commits in this pull request duplicate the commits in #49 . How easy will it be to merge that, reimplement the actual changes from this branch on a new branch, and then issue a new pull request? Sorry it took me so long to get to this. |
rbiswas4
added a commit
that referenced
this pull request
Sep 26, 2016
Twinkles catalog 2: - Implements the ability to read SN model parameters off fatboy database tables - produce input catalogs for phoSim - tests pass with latest commit : https://ci.lsst.codes/job/stack-os-matrix/16312/label=centos-6,python=py2/console - Discussed changes implemented - Will Close #49 and #51 which are superseded by the implementation here and some previous commits - Close Jira SIM-1759
|
This is superseded by #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function to obtain the rest frame SN spectrum,
Within the model range,