DM-43199: Move to black and isort #91
Conversation
mfisherlevine
force-pushed
the
tickets/DM-43199
branch
from
849cdd8
to
9efa40c
Compare
setup.cfg
Outdated
| # N816: mixed case variable in class scope | ||
| # W503: line break after binary operator, flake8 disagrees with PEP-8 | ||
| # W504: Line break occurred after a binary operator | ||
| ignore = E133, E203, E226, E228, N802, |
There was a problem hiding this comment.
I think E133 and E226 are impossible once you are enforcing black.
setup.cfg
Outdated
| # W504: Line break occurred after a binary operator | ||
| ignore = E133, E203, E226, E228, N802, | ||
| N803, N806, N812, N813, N815, | ||
| N816, W503, W504 |
There was a problem hiding this comment.
I have W503 set in middleware packages and that's the one listed in the developer guide.
There was a problem hiding this comment.
Unless there's a good reason to remove one of these, I'd probably lean towards keeping it, because it can be very annoying battling these sometimes. Is there a good reason to remove W504, do you think? Or is it more of a case of needing one, but not both?
There was a problem hiding this comment.
You can't have W503 and W504, you have to pick one for flake8 (they mean opposite things). We pick W503 because that matches black.
There was a problem hiding this comment.
and then I messed up my comment and said W504 by mistake (now fixed)
There was a problem hiding this comment.
Well, they're rules to ignore, so I'd have thought you can pick all of them... but sure, will remove W504.
No description provided.