Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-aria-modal from 4.0.2 to 5.0.0 in /ui #778

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 12, 2023

Bumps react-aria-modal from 4.0.2 to 5.0.0.

Release notes

Sourced from react-aria-modal's releases.

5.0.0

  • Remove react-displace package from dependencies
  • Update focus-trap-react package to v10.1.4
  • Add support for React 18
  • Note: 5.0.0 introduces a breaking change to implementations where ref is referenced when the component is mounted:

Before

class Test extends React.Component {
  constructor(props) {
    super(props);
    this.contentRef = React.createRef();
  }
componentDidMount() {
// with react-aria-modal@4 it will print "{ current: div }"
// now it will print "{ current: null }"
console.log(this.contentRef);
}
render() {
return (
<div>
<AriaModal titleText="Test">
<div ref={this.contentRef}>
Modal window content...
<br/>
<button>ok</button>
</div>
</AriaModal>
</div>
);
}
}

After

The problem can be easily fixed in client code:

class DemoEleven extends React.Component {
  handleRef = divElement => {
    console.log(divElement);
  }
render() {
return (
<div>
</tr></table>

... (truncated)

Changelog

Sourced from react-aria-modal's changelog.

5.0.0

  • Remove react-displace package from dependencies
  • Update focus-trap-react package to v10.1.4
  • Add support for React 18
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 12, 2023
@rra
Copy link
Member

rra commented Jun 12, 2023

@dependabot rebase

Bumps [react-aria-modal](https://github.com/davidtheclark/react-aria-modal) from 4.0.2 to 5.0.0.
- [Release notes](https://github.com/davidtheclark/react-aria-modal/releases)
- [Changelog](https://github.com/davidtheclark/react-aria-modal/blob/master/CHANGELOG.md)
- [Commits](davidtheclark/react-aria-modal@4.0.2...5.0.0)

---
updated-dependencies:
- dependency-name: react-aria-modal
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ui/react-aria-modal-5.0.0 branch from 6e66a7c to 65fe639 Compare June 12, 2023 15:23
@rra rra enabled auto-merge June 12, 2023 15:24
@rra rra merged commit 8accbcb into main Jun 12, 2023
5 checks passed
@rra rra deleted the dependabot/npm_and_yarn/ui/react-aria-modal-5.0.0 branch June 12, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant