DM-43288: Add a health check endpoint #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new internal endpoint, /health, which checks the database, Redis, and (if configured) LDAP and raises an uncaught exception if any of them fail. This will be used as a Kubernetes liveness check to address the issues we've had with Gafaelfawr recovering from Redis or LDAP outages and losing its database connections.
|
This seemed worth a code review, not because the code is all that complex, but because I wasn't sure if you had any thoughts about the best way to structure health checks like this. We'll eventually want to add these to more applications (and in some cases will need to implement the IVOA availability endpoint). |
jonathansick
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new internal endpoint, /health, which checks the database, Redis, and (if configured) LDAP and raises an uncaught exception if any of them fail. This will be used as a Kubernetes liveness check to address the issues we've had with Gafaelfawr recovering from Redis or LDAP outages and losing its database connections.