Implement dashboard generation from built-in templates #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first sketch of a dashboard generation service+domain implementation in LTD Keeper itself. - BuiltinTemplateProvider coordinates built-in templates; when we implement S3-based templates we'll create an S3TemplateProvider with a similar API. - Context provides dataclass instances that provide information for the dashboard that are adapted from the DB models.
We're using ltd-conveyor's s3 functions for uploading objects and directories.
jonathansick
force-pushed
the
u/jsickcodes/builtin-dashboard
branch
2 times, most recently
from
4b2e0ba
to
0fdb8e4
Compare
This fixes some upload issues we found for individual objects into the bucket.
You can now see the dashboard built with mock data in dashboard_dev/ by running the test_dashboard_template.py module. This enables you to quickly refine the built-in template.
jonathansick
force-pushed
the
u/jsickcodes/builtin-dashboard
branch
from
e02282f
to
42b0ecb
Compare
jonathansick
force-pushed
the
u/jsickcodes/builtin-dashboard
branch
from
42b0ecb
to
11229f6
Compare
Normally main editions should be marked with EditionKind.main, however if they aren't these extra tests ensure they don't appear in the releases or drafts lists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements dashboard generation for LTD Keeper v2. This functionality was originally part of LTD Dasher. Since LTD Keeper v2 now support multiple missions, the dashboard generation code is being moved into LTD Keeper itself for easier maintainability.
The ultimate intent is for each organization to develop and configure their own dashboard HTML templates and assets. The default template though, will be built-in. This PR implements that
BuiltinTemplateProviderand also enables us to develop other infrastructure related to dashaboard templates such as Jinja context objects and S3 uploading.