DM-41630: Update development Redis dependencies #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis-py 5.0.0 changed the async close method from close to aclose, and types-redis is no longer accurate for the library. Drop the types-redis development dependency, add a versioned development dependency, and use aclose instead of close to avoid a warning when running the test suite.
rra
force-pushed
the
tickets/DM-41630a
branch
from
ab0c437
to
8998c1c
Compare
jonathansick
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis-py 5.0.0 changed the async close method from close to aclose, and types-redis is no longer accurate for the library. Drop the types-redis development dependency, add a versioned development dependency, and use aclose instead of close to avoid a warning when running the test suite.