Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v2 of #10.
It turns out that
type
is the right field to use when pulling from thestatus
of a Kafka resource in Strimzi. I was confused because I was looking at pulling it from thespec
of a Kafka resource. For historical reasons,type
is used to denote the name of the listener in the status of a Kafka custom resource.So, the existing code was totally valid - it just only works if the internal listener is named
tls
. This change makes that configurable.Along the way, I fixed the pytest-flake8 CI bug, and updated the CRD to include a spec.