Update default listener to tls and strimzi CRD version to v1beta2 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
changed the title
jonathansick
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Right. This is consistent with our Helm chart, so our Kustomize deployment should work the same way too.
|
I'll put this out in a 0.5.0 release. |
|
Oh, sorry I read this backwards (needed coffee!). I got the direction of the change wrong. I think I'll need to revert the default listener this for consistency with our Helm chart and what Rubin considers to be an ideal default; but document better that this setting is needed for a tls-secured listener. |
jonathansick
changed the title
|
I think I've got my head around what's happening with listeners, written up in #51. I'll get this out in a beta and see if it works for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #49