DM-43173: Update to ruff linting and pydantic 2 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
force-pushed
the
tickets/DM-43173
branch
from
8df33af
to
f86b649
Compare
Ruff replaces the combination of flake8, black, and isort. While doing this we also upgraded dependencies and realized that Pydantic would tick up to Pydantic 2, so all of these changes are unfortunately happening at the same time.
jonathansick
force-pushed
the
tickets/DM-43173
branch
2 times, most recently
from
d01a5e7
to
fb5ea08
Compare
This is the slightly more future-proof way of defining Fields, as opposed to making the field the default value. This may not be strictly necessary though?
It seems that Annotated doesn't work well with Pydantic SecretStr. For now we'll convert these to just str and also require values (use foo values for unit testing and set the enable_github_app config to false for testing).
jonathansick
force-pushed
the
tickets/DM-43173
branch
from
fb5ea08
to
2a4d173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codebase upgrades to Times Square prior to restarting development: