DM-35535: Fix autoupdate for current pages #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
approved these changes
Jul 12, 2022
| @@ -1,5 +1,5 @@ | |||
| {% extends "single_event.jinja" %} | |||
| {% block footer_scripts %} | |||
| <script src="//ajax.googleapis.com/ajax/libs/jquery/1.9.1/jquery.min.js"></script> | |||
| <script type=text/javascript src="/rubintv/static/js/refresh-current.js"></script> | |||
| <script type=text/javascript src="/rubintv/static/js/refresh-current.js?v=1234"></script> | |||
There was a problem hiding this comment.
This doesn't affect present functionality, but I'd recommend a more automated approach to cache-busting, like a Jinja function or environment context that provides a dynamically calculated hash of the script file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.