DM-35680: Implement cache busting for RubinTV #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugyballoons
force-pushed
the
tickets/DM-35680
branch
from
836537f
to
0dde1ec
Compare
jonathansick
approved these changes
Jul 26, 2022
requirements/dev.in
Outdated
|
|
||
| -c main.txt | ||
|
|
||
| aiohttp-devtools | ||
| coverage[toml] | ||
| google-cloud-storage | ||
| jinja2 | ||
| aiohttp-jinja2 |
There was a problem hiding this comment.
This (and probably also jinja2, and google-cloud-storage) only need to be in requirements/main.in because they're runtime dependencies. The things we put in requirements/dev.in are additional dependencies that get installed in the development/testing environments for running tests. So basically, replicating the runtime dependences here doesn't do anything.
There was a problem hiding this comment.
That makes sense now 👍
| @@ -3,14 +3,15 @@ | |||
| # as implicit dev dependencies with constrained versions. | |||
| # | |||
| # After editing, update requirements/dev.txt by running: | |||
| # make update-deps | |||
| # make update | |||
There was a problem hiding this comment.
Just fyi that update calls make update-deps, but also re-installs your environment.
There was a problem hiding this comment.
Useful to know, thanks!
ugyballoons
force-pushed
the
tickets/DM-35680
branch
from
785bd1b
to
82154ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.