This repository has been archived by the owner on Sep 29, 2022. It is now read-only.
Feature/couger01/dm 18753 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at_pneumatics_sim - Removed at_hexapod_sim dockerfile
… soon as the container is started.
- added running integration tests to readme in Compose/Simulators - Added integration test scripts to docker image simulation_tests - Added simulation-tests image to docker-compose for simulators
tribeiro
reviewed
May 13, 2019
Compose/Simulators/README.md
Outdated
|
|
||
| Clone the ts_Dockefiles repository: | ||
| ```sh | ||
| $ git clone -b feature/couger01/dm-18753 https://github.com/lsst-ts/tsDockerfiles.git |
There was a problem hiding this comment.
Fix link to ts_Dockerfiles repo... should be https://github.com/lsst-ts/ts_Dockerfiles.git not https://github.com/lsst-ts/tsDockerfiles.git
tribeiro
reviewed
May 13, 2019
There was a problem hiding this comment.
General recommendation...
lsstts/develop-env:develop is a moving target. The develop tag is updated frequently, I would recommend figuring out the date tag and using that instead. Just a recommendation to make sure the containers build properly (see what happened with the ATAOS).
tribeiro
approved these changes
May 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS auxtel simulators excluding athexapod.