Tickets/dm36232: Install ts-integrationtests and robotframework_EFD to integrationtests image #148
Conversation
rbovill
force-pushed
the
tickets/DM-36232
branch
3 times, most recently
from
23d1c4a
to
af07aef
Compare
|
I just merged my PR, you may want to rebase your branch to main before merging the PR.. Also, remember to update the version history. |
…nt (there's one in the deploy-env image).
…ests and robotframework conda packages and checking out the robotframework_EFD repo. Explicitly checking out the main and develop branches of the robotframework_EFD repo.
…e-build conventions and removed obsolete steps. Added a startup.sh script. Updated the README to accurately document the Dockerfile.
rbovill
force-pushed
the
tickets/DM-36232
branch
from
af07aef
to
74378cd
Compare
rbovill
force-pushed
the
tickets/DM-36232
branch
from
05514d8
to
c86ef85
Compare
build/integrationtests/Dockerfile
Outdated
| @@ -1,23 +1,29 @@ | |||
| ARG cycle | |||
| ARG hub | |||
| ARG integrationtests | |||
There was a problem hiding this comment.
If I remember correctly, all the args defined before the "FROM" clause are wiped out just after it.
Also, it is best if you use the ARGS close to where you need it which, in this case, is just after line 13...
This makes sure the layers are better reused when you change their values...
build/integrationtests/Dockerfile
Outdated
| LABEL maintainer Rob Bovill <rbovill@lsst.org> | ||
| LABEL integrationtests=${integrationtests} |
There was a problem hiding this comment.
Consider adding this LABEL at the end of the build, or at least after you install the package.. This helps docker build reuse layers.
You can see how we do on the other build, e.g.:
ts_cycle_build/build/ataos/Dockerfile
Lines 55 to 58 in c318fd5
build/integrationtests/Dockerfile
Outdated
|
|
||
| LABEL integrationtests=${integrationtests} | ||
| WORKDIR ${HOME}/robotframework_EFD | ||
| RUN ${HOME}/.checkout_repo.sh main develop |
There was a problem hiding this comment.
you just cloned the repo a couple lines above, do you need to do this?
There was a problem hiding this comment.
I guess we'll only want main for the actual executions. Removed.
…ture; right now it is just dummy command. The RUN_ARG value will be updated once we determine what it should do.
No description provided.