Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21467: Implement BaseMockController and Server #1

Merged
merged 2 commits into from
Oct 9, 2019
Merged

DM-21467: Implement BaseMockController and Server #1

merged 2 commits into from
Oct 9, 2019

Conversation

r-owen
Copy link
Collaborator

@r-owen r-owen commented Oct 4, 2019

No description provided.

@r-owen r-owen requested a review from teweitsai October 8, 2019 15:46
teweitsai
teweitsai approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@teweitsai teweitsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and convincible! Great job!

@r-owen r-owen force-pushed the tickets/DM-21467 branch 6 times, most recently from e2e6a21 to 6638a9b Compare October 9, 2019 20:16
@r-owen r-owen merged commit e3e0829 into develop Oct 9, 2019
@r-owen r-owen deleted the tickets/DM-21467 branch October 9, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teweitsai teweitsai teweitsai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-owen @teweitsai