DM-28230: fix the RotatorCommander #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-28230
branch
from
dcbe988
to
2e078b2
Compare
The class overrode a base class method, with a different call signature. This broke output of some telemetry some topics. Note: this class can be simplified once we require ts_salobj 6.2, because that adds support for ignoring certain telemetry fields when deciding whether to output new data.
r-owen
force-pushed
the
tickets/DM-28230
branch
from
2e078b2
to
743c7d6
Compare
teweitsai
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It overrode a standard method with a different signature, which broke some telemetry topics.