DM-11162: Replace all use of Coord and subclasses with SpherePoint #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-11162
branch
3 times, most recently
from
d50bf30
to
596b759
Compare
Add getPosition and getTangentPlaneOffset methods from Coord to SpherePoint. Simplify the former by requiring the units argument and not treating hours specially. Fix documentation errors in the latter (it claimed the offset was to "this" but it's from "this").
Some exising users of Coord rely on a default constructor, so add one to SpherePoint.
r-owen
force-pushed
the
tickets/DM-11162
branch
from
596b759
to
62a913d
Compare
rearmstr
reviewed
Mar 22, 2018
python/lsst/afw/coord/__init__.py
Outdated
| from .utils import * | ||
| from ._observatory import * | ||
| from ._weather import * | ||
| from ._weather import * |
rearmstr
reviewed
Mar 22, 2018
src/geom/Endpoint.cc
Outdated
| this->_assertNAxes(this->_getNAxes(data)); | ||
| return coord::IcrsCoord(data[0] * radians, data[1] * radians); | ||
| return SpherePoint(data[0] * radians, data[1] * radians); |
There was a problem hiding this comment.
Any reason not to use the SpherePoint(data[0], data[1], radians) constructor here and below?
There was a problem hiding this comment.
Good idea. I'll do it.
rearmstr
reviewed
Mar 22, 2018
src/geom/detail/frameSetUtils.cc
Outdated
| #include "lsst/afw/fits.h" | ||
| #include "lsst/afw/geom/Angle.h" | ||
| #include "lsst/afw/geom/Point.h" | ||
| #include "lsst/afw/geom/SpherePoint.h" |
There was a problem hiding this comment.
Does this file need to be included here?
r-owen
force-pushed
the
tickets/DM-11162
branch
from
62a913d
to
c646c3c
Compare
and related classes and functions, including CoordSystem, makeCoord, makeCoordEnum, and assertCoordsAlmostEqual
in test_warpExposure.py
The simple.cc pybind11 wrapper imports lsst.afw.coord. It should not be necessary, but removing it causes problems so I made a note with a reference to a possibly relevant RFC.
r-owen
force-pushed
the
tickets/DM-11162
branch
from
c646c3c
to
7de6782
Compare
rearmstr
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.