-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-11162: Replace all use of Coord and subclasses with SpherePoint #332
Merged
Commits on Mar 17, 2018
-
Add missing Coord methods to SpherePoint
Add getPosition and getTangentPlaneOffset methods from Coord to SpherePoint. Simplify the former by requiring the units argument and not treating hours specially. Fix documentation errors in the latter (it claimed the offset was to "this" but it's from "this").
Configuration menu - View commit details
-
Copy full SHA for ad1c281 - Browse repository at this point
Copy the full SHA ad1c281View commit details -
Add default SpherePoint constructor
Some exising users of Coord rely on a default constructor, so add one to SpherePoint.
Configuration menu - View commit details
-
Copy full SHA for 2a57093 - Browse repository at this point
Copy the full SHA 2a57093View commit details -
Configuration menu - View commit details
-
Copy full SHA for 294ad7f - Browse repository at this point
Copy the full SHA 294ad7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a73ed07 - Browse repository at this point
Copy the full SHA a73ed07View commit details
Commits on Mar 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9d3f4b8 - Browse repository at this point
Copy the full SHA 9d3f4b8View commit details -
and related classes and functions, including CoordSystem, makeCoord, makeCoordEnum, and assertCoordsAlmostEqual
Configuration menu - View commit details
-
Copy full SHA for 3b71d16 - Browse repository at this point
Copy the full SHA 3b71d16View commit details -
Configuration menu - View commit details
-
Copy full SHA for f398965 - Browse repository at this point
Copy the full SHA f398965View commit details -
Configuration menu - View commit details
-
Copy full SHA for 780a65c - Browse repository at this point
Copy the full SHA 780a65cView commit details -
Add a note about a strange py wrapper import
The simple.cc pybind11 wrapper imports lsst.afw.coord. It should not be necessary, but removing it causes problems so I made a note with a reference to a possibly relevant RFC.
Configuration menu - View commit details
-
Copy full SHA for 7de6782 - Browse repository at this point
Copy the full SHA 7de6782View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.