Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-11162: Replace all use of Coord and subclasses with SpherePoint #332

Merged
merged 9 commits into from
Mar 23, 2018

Commits on Mar 17, 2018

  1. Add missing Coord methods to SpherePoint

    Add getPosition and getTangentPlaneOffset methods from Coord
    to SpherePoint. Simplify the former by requiring the units argument
    and not treating hours specially. Fix documentation errors in the
    latter (it claimed the offset was to "this" but it's from "this").
    r-owen committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    ad1c281 View commit details
    Browse the repository at this point in the history
  2. Add default SpherePoint constructor

    Some exising users of Coord rely on a default constructor,
    so add one to SpherePoint.
    r-owen committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    2a57093 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    294ad7f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a73ed07 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2018

  1. Configuration menu
    Copy the full SHA
    9d3f4b8 View commit details
    Browse the repository at this point in the history
  2. Remove the Coord classes

    and related classes and functions, including CoordSystem, makeCoord, makeCoordEnum,
    and assertCoordsAlmostEqual
    r-owen committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    3b71d16 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f398965 View commit details
    Browse the repository at this point in the history
  4. Standardize import of Weather & Observatory

    in test_warpExposure.py
    r-owen committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    780a65c View commit details
    Browse the repository at this point in the history
  5. Add a note about a strange py wrapper import

    The simple.cc pybind11 wrapper imports lsst.afw.coord.
    It should not be necessary, but removing it causes problems
    so I made a note with a reference to a possibly relevant RFC.
    r-owen committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    7de6782 View commit details
    Browse the repository at this point in the history