DM-14353: remove or fix bad C++ usage in FootprintSet.cc #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Sogo Mineo (NAOJ) who identified the bug through gcc 8.1 and provided the fix.
The code in the removed block that not already been #ifdef'd out was rife with serious errors that had gone unnoticed until recently because they were in templates that were not being instantiated (because they were only used in code that had been #ifdef'd out).
IdSpan is barely larger than shared_ptr itself, and holding it by value avoids both an extra level of indirection and a lot of thread-atomic reference counting.
|
Please don't squash that "remove disabled ..." changeset. The algorithm (a flood-fill) was used in peak culling and may need to be brought back to life. Removing it now is fine. |
PaulPrice
approved these changes
May 8, 2018
src/detection/FootprintSet.cc
Outdated
| @@ -714,15 +714,15 @@ static void findFootprints( | |||
| } | |||
|
|
|||
| if (in_span) { | |||
| auto sp = std::make_shared<IdSpan>(in_span, y, x0, width - 1, good); | |||
| IdSpan sp(in_span, y, x0, width - 1, good); | |||
| spans.push_back(sp); | |||
There was a problem hiding this comment.
Suggest using emplace_back, here and above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of stylistic things that I have not touched; I'm just trying to fix code that is incorrect, likely to emit warnings, or bad in a way that could affect performance.