Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14353: remove or fix bad C++ usage in FootprintSet.cc #351

Merged
merged 6 commits into from
May 11, 2018

Commits on May 8, 2018

  1. fix return type for Startspan::getSpan

    Thanks to Sogo Mineo (NAOJ) who identified the bug through gcc 8.1 and
    provided the fix.
    PaulPrice committed May 8, 2018
    Configuration menu
    Copy the full SHA
    101f826 View commit details
    Browse the repository at this point in the history
  2. Remove disabled and buggy alternate detection code.

    The code in the removed block that not already been #ifdef'd
    out was rife with serious errors that had gone unnoticed until
    recently because they were in templates that were not being
    instantiated (because they were only used in code that had
    been #ifdef'd out).
    TallJimbo committed May 8, 2018
    Configuration menu
    Copy the full SHA
    7737759 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd10c21 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    feb4c3f View commit details
    Browse the repository at this point in the history
  5. Hold IdSpan by value, not shared_ptr.

    IdSpan is barely larger than shared_ptr itself, and
    holding it by value avoids both an extra level of
    indirection and a lot of thread-atomic reference counting.
    TallJimbo committed May 8, 2018
    Configuration menu
    Copy the full SHA
    9e3acdb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2018

  1. Configuration menu
    Copy the full SHA
    f8bdd62 View commit details
    Browse the repository at this point in the history