DM-30829: Add persistence for WarpingControl #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Looks good to me. Just a couple small inline questions for my own c++ education.
While you're at this, in Persistable.h:67, could you change PersistenceFactory to PersistableFactory? This has bothered me for a while but I've been too lazy to do anything about it. Now seems like a good time.
| protected: | ||
| void setKernelParameter(unsigned int ind, double value) const override; | ||
|
|
||
| std::string getPersistenceName() const override { return "LanczosWarpingKernel"; } |
There was a problem hiding this comment.
Why make isPersistable noexcept and not getPersistenceName or getPythonModule? Is it just that allocating the std::string return might fail?
kfindeisen
force-pushed
the
tickets/DM-30829
branch
from
4ba550a
to
55a094a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
WarpingControlaPersistableand implements persistence. Since aWarpingControlmay contain arbitrary kernels (not just the designated "warping" kernels), representing the state required making the kernels typically used withWarpingControlpersistable as well. These were given only skeletal support, however, on the assumption that they would only be persisted as subobjects.