DM-30829: Add persistence for WarpedPsf #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assumed the file was previously current through 2019, but that all new 2020-2021 entries are valid.
kfindeisen
force-pushed
the
tickets/DM-30829
branch
from
f2786d1
to
29b5596
Compare
jmeyers314
approved these changes
Jun 24, 2021
tests/test_warpedPsf.cc
Outdated
| @@ -247,24 +309,23 @@ BOOST_AUTO_TEST_CASE(warpedPsf) | |||
| unwarped_psf->evalABC(a, b, c, q); | |||
|
|
|||
| Eigen::Matrix2d m0; | |||
| m0 << a, b, | |||
| b, c; | |||
| m0 << a, b, b, c; | |||
There was a problem hiding this comment.
I assume this is to make clang-format happy? Is there a way to do that and keep it obvious that these are entries in a 2x2 matrix like before?
There was a problem hiding this comment.
Sorry, I just blindly ran clang-format. Since I'm not familiar enough with Eigen to know if there's another way to write this, I'll just revert.
There was a problem hiding this comment.
Aha, there's a workaround: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#disabling-formatting-on-a-piece-of-code
This included updating the copyright statement, removing PTR and CONST_PTR, and running clang-format. Some lines dealing with coefficients and matrices have been excluded from clang-format, to let them use formatting that implies a 2D state.
This is consistent with the intent of the class (a classic decorator pattern) and avoids the need to specialize ImagePsfTrampoline for WarpedPsf.
kfindeisen
force-pushed
the
tickets/DM-30829
branch
from
29b5596
to
554f0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements persistence for
WarpedPsf. The adopted persisted form is merely the concatenation of the three subobjects currently making up theWarpedPsfimplementation, as I don't see a more generic way to represent that state. Depends on lsst/afw#597.